[llvm] r304232 - [Object] Fix pessimizing move.

[Benjamin Kramer via llvm-commits]

Author: d0k
Date: Tue May 30 14:36:58 2017
New Revision: 304232

URL: http://llvm.org/viewvc/llvm-project?rev=304232&view=rev
Log:
[Object] Fix pessimizing move.

Returning the Error by value triggers copy elision, the move is more
expensive. Clang rightfully warns about it.

Modified:
    llvm/trunk/lib/Object/WindowsResource.cpp

Modified: llvm/trunk/lib/Object/WindowsResource.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/WindowsResource.cpp?rev=304232&r1=304231&r2=304232&view=diff
==============================================================================
--- llvm/trunk/lib/Object/WindowsResource.cpp (original)
+++ llvm/trunk/lib/Object/WindowsResource.cpp Tue May 30 14:36:58 2017
@@ -20,7 +20,7 @@ namespace object {
 
 #define RETURN_IF_ERROR(X)                                                     \
   if (auto EC = X)                                                             \
-    return std::move(EC);
+    return EC;
 
 const uint32_t MIN_HEADER_SIZE = 7 * sizeof(uint32_t) + 2 * sizeof(uint16_t);