[polly] r302636 - [Polly] Canonicalize arrays according to base-ptr equivalence class

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 11:32:08 PDT 2017


On Tue, May 30, 2017, at 07:09 PM, Michael Kruse via llvm-commits wrote:
> 2017-05-30 18:38 GMT+02:00 Tobias Grosser <tobias at grosser.es>:
> > We do not use setNewAccess relation any more, right? I dropped this on
> > your request.
> 
> Mmh, I seem to have missed that you introduced setAccessRelation(). I
> remember you said you were using setNewAccessRelation() on purpose and
> me not being able to think of a situation where it could fail.

Not sure about the precise history, but I somehow remember I wanted to
use setAccessRelation and it did not work due to some cleanups that had
to take place first. You raised some concerns about
setNewAccessRelation, which motivated me to push the cleanups and I then
came to the conclusion that using setAccessRelation instead of
setNewAccessRelation is what we agreed is better.

Hope I did not oversee anything.

Best,
Tobias


More information about the llvm-commits mailing list