[PATCH] D33651: [ADT] Add convenience functions for making forward and reverse ranges with an STL container.

Frederich Munch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 08:53:19 PDT 2017


marsupial added inline comments.


================
Comment at: include/llvm/ADT/iterator_range.h:75-87
+template <typename T>
+iterator_range<typename T::reverse_iterator> reverse_range(T &C) {
+  return iterator_range<typename T::reverse_iterator>(C.rbegin(), C.rend());
+}
+
+template <typename T>
+iterator_range<typename T::const_iterator> make_range(const T &C) {
----------------
majnemer wrote:
> Doesn't `reverse_range` duplicate the `reverse` we already have in STLExtras.h?
Thats all I really wanted...Should I add a comment it's there?


https://reviews.llvm.org/D33651





More information about the llvm-commits mailing list