[PATCH] D33594: [mips][dsp] Modify repl.ph to accept signed immediate values

[Simon Dardis via Phabricator via llvm-commits]

sdardis requested changes to this revision.
sdardis added a comment.
This revision now requires changes to proceed.

You also need to update:

Failing Tests (2):

  LLVM :: MC/Mips/dsp/invalid.s
  LLVM :: MC/Mips/micromips-dsp/valid.s

Could you also ensure the ranges are fully checked in the invalid cases in the invalid test for both dsp and micromips-dsp?.



================
Comment at: lib/Target/Mips/MipsDSPInstrInfo.td:21-22
 def immZExt10 : ImmLeaf<i32, [{return isUInt<10>(Imm);}]>;
+def immSExt10 : ImmLeaf<i32, [{return isInt<10>(Imm);}]>;
 def immSExt6 : ImmLeaf<i32, [{return isInt<6>(Imm);}]>;
 
----------------
These two should be in ascending order.


https://reviews.llvm.org/D33594