[PATCH] D33400: [mips] Add madd4 subtarget feature

[Simon Dardis via Phabricator via llvm-commits]

sdardis requested changes to this revision.
sdardis added a comment.
This revision now requires changes to proceed.

This requires a test. Can you bring back test/CodeGen/Mips/fmad1.ll and add some additional RUN lines where madd/msub/etc is disabled, and check that madd/msub/etc aren't generated?



================
Comment at: lib/Target/Mips/Mips.td:188
 
+def FeatureMadd4 : SubtargetFeature<"disable_madd4", "DisableMadd4", "true",
+                                    "4-operand madd.s and related instructions">;
----------------
This should be "nomadd4" rather than "disable_madd4".


================
Comment at: lib/Target/Mips/Mips.td:189
+def FeatureMadd4 : SubtargetFeature<"disable_madd4", "DisableMadd4", "true",
+                                    "4-operand madd.s and related instructions">;
+
----------------
"Disable 4-operand madd.fmt and related instructions".


https://reviews.llvm.org/D33400