[PATCH] D31528: [ELF][MIPS] Multi-GOT implementation

[Rafael Avila de Espindola via llvm-commits]

Simon Atanasyan via llvm-commits <llvm-commits at lists.llvm.org> writes:

> In general, requirement to remove incompatibilities from MIPS ABI
> looks like a requirement to make MIPS ISA more similar to say X86 ISA
> for simplification of LLVM MC library code base. MIPS requires new ABI
> and finally I think it gets the new ABI, but I do not expect that this
> makes LLD code base smaller and cleaner.

But you must agree that there is a point where a system is so odd that
it is just not worth supporting it in a general tool.

If a new system comes out with non-ieee floats, register windows, its
own file format, middle endian and non-8 bit bytes, we should probably
not support it.

The mips ABI is not that bad, but we should at least put an effort to
localize it. If we could have

if (mips)
  patchForMips();

Just after relocation processing and avoid having to have mips specific
logic in the relocation scan and in the dynamic relocation
representation this patch would be way easier to accept.

Cheers,
Rafael