[PATCH] D33529: Allow clients to specify search order of DynamicLibraries.

[Philippe Canal via Phabricator via llvm-commits]

pcanal added inline comments.


================
Comment at: include/llvm/Support/DynamicLibrary.h:96
+      SO_Linker,
+      /// SO_LoadedFirst - Search all loaded libraries then as SO_Linker would
+      SO_LoadedFirst,
----------------
marsupial wrote:
> pcanal wrote:
> > Did you mean "Search all loaded libraries as the SO_Linker would" ?
> No, its what I think you are for.
> The process does not have priority.
> 
> BTW, In case it wasn't clear: using this on Windows can cause real problems as a lot of C++ runtime can be exported via the binary (though I understand you want to preserve behavior ROOT has on Unix).
> No, its what I think you are for.

My bad. I mis-parsed the sentence, maybe adding a comma would have helped me: "Search all loaded libraries, then as the SO_Linker would".

Another point you might consider clarifying in the doc is whether the search of the libraries in SO_LoadedFirst and SO_LoadedLast is done in load order ('oldest first') or reverse load order ('newest first') [which is the closest to 'dependency order')


https://reviews.llvm.org/D33529