[PATCH] D33655: [Cloning] Take another pass at properly cloning debug info

Gor Nishanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 29 14:00:07 PDT 2017


GorNishanov added a comment.

Looks good from a coroutine side. Though I am not fluent in DebugInfo to LGTM the whole change.

One comment about "ModuleLevelChanges" parameter.
Is the description of that parameter accurately captures its purpose?

Namely:
/// If ModuleLevelChanges is false, VMap contains no non-identity GlobalValue
/// mappings.


https://reviews.llvm.org/D33655





More information about the llvm-commits mailing list