[PATCH] D31494: [PowerPC] Pretty-print CR bits the way the binutils disassembler does

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai marked an inline comment as done.
nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp:451
+static const char *stripRegisterPrefix(const char *RegName, unsigned RegNum) {
+  if (FullRegNames || ShowVSRNumsAsVR) {
+    if (RegNum >= PPC::CR0EQ && RegNum <= PPC::CR7UN) {
----------------
hfinkel wrote:
> nemanjai wrote:
> > hfinkel wrote:
> > > This ShowVSRNumsAsVR seems broken ; should we just get rid of it?
> > Can you elaborate a bit on why you feel it's broken? It should just display things like `vs34` as `v2` and we use it here just to prevent the `v` from getting stripped from the output.
> I should have been more specific. I meant that it seems incorrect that ShowVSRNumsAsVR is equivalent to FullRegNames here (it is affecting much more than just the vector registers).
Ah, that makes sense. Basically get rid of the semantics where `ShowVSRNumsAsVR` implies `FullRegNames`.


Repository:
  rL LLVM

https://reviews.llvm.org/D31494