[PATCH] D33513: [ThinLTO] Fix ThinLTO crash while destroying context

[Charles Saternos via Phabricator via llvm-commits]

ncharlie marked 4 inline comments as done.
ncharlie added inline comments.


================
Comment at: tools/llvm-dis/llvm-dis.cpp:145-147
   std::unique_ptr<Module> M =
       ExitOnErr(getOwningLazyBitcodeModule(std::move(MB), Context,
+                                           /*ShouldLazyLoadMetadata=*/true, true));
----------------
dexonsmith wrote:
> I haven't thought about whether this should be hardcoded (likely depends on whether we're losing important coverage in the `false` case -- have you looked at that?), but there should certainly be a `/*What is this doing?=*/` comment.
Yup, just ran the test suite and a few tests will fail if I hard-code it. Should I just add a hidden flag to the `llvm-dis` utility then?


https://reviews.llvm.org/D33513