[PATCH] D33621: Fix for -wrap linker option and LTO, PR 33145

[Rafael Avila de Espindola via llvm-commits]

> +  bool isBitcode() const { return IsBitcode; }

Why can't you use the existing File in SymbolBody?

>  template <class ELFT> struct Symtab { static SymbolTable<ELFT> *X; };
> Index: lld/ELF/SymbolTable.cpp
> ===================================================================
> --- lld/ELF/SymbolTable.cpp
> +++ lld/ELF/SymbolTable.cpp
> @@ -118,8 +118,9 @@
>    // Compile bitcode files and replace bitcode symbols.
>    LTO.reset(new BitcodeCompiler);
>    for (BitcodeFile *F : BitcodeFiles)
> -    LTO->add(*F);
> +    LTO->add(*F, RenamedSymbols);
>  
> +  PostLTO = true;

Why do you need to store this flag? All LTO produced files are added
from addCombinedLTOObject, so you should be able to pass any extra info
from there.

> +template <class ELFT> void SymbolTable<ELFT>::addLTOSymbolWrap(StringRef Name) {
> +  Twine WrappedName = "__wrap_" + Name;
> +  Twine RealName = "__real_" + Name;

These temporary Twines are not safe and they are only used once anyway.

Cheers,
Rafael