[PATCH] D33646: [ELF] - Do not crash when linkerscript applies fill to .bss.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon May 29 10:46:07 PDT 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> grimar created this revision.
> Herald added a subscriber: emaste.
>
> I found that during visual inspection of code while wrote different patch.
> Script in testcase probably have nothing common with real life, but
> we segfault currently using it.
>
> I think if output section is known NOBITS, there is no need to create
> writers threads for doing nothing or proccess any filler logic that is useless here.
> We can just early return, that is what this patch do.

Should we error?

What do gold and bfd do? LGTM if they also just ignore this.

Cheers,
Rafael


More information about the llvm-commits mailing list