[PATCH] D33443: Fix PR33031: Cannot scavenge register without an emergency spill slot.

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:160
+            AArch64FrameOffsetCannotUpdate)
+          return 0;
+      }
----------------
MatzeB wrote:
> MatzeB wrote:
> > How about putting an extra `assert(Offset < 255);` here to be sure?
> or rather `assert(Offset < 256);` I guess.
The AArch64FrameOffsetCannotUpdate return value should already guarantee that Offset must remain 0; but it doesn't hurt to add the assert.
I'll do that and commit after I've finished running a bootstrap test on this patch.
The regression tests (obviously) and the test-suite pass.


https://reviews.llvm.org/D33443