[PATCH] D33443: Fix PR33031: Cannot scavenge register without an emergency spill slot.

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 29 07:52:31 PDT 2017


kristof.beyls updated this revision to Diff 100614.
kristof.beyls added a comment.

Thanks all for the review comments!

I believe I've addressed them all in this updated patch.
I've dropped introducing the command line option -reg-scavenging-always-use-spill-slot. In the end I realized (should have realized that earlier), that with running a single pass in llc, it is possible to write a pretty stable test, even if register pressure must be extremely high in exactly the right place in the code.
I think the new regression test for this now looks nice, and definitely nice enough to not pollute the register scavenger with a special mode just for testing.


https://reviews.llvm.org/D33443

Files:
  lib/Target/AArch64/AArch64FrameLowering.cpp
  test/CodeGen/AArch64/reg-scavenge-frame.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33443.100614.patch
Type: text/x-patch
Size: 4281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170529/94817f12/attachment.bin>


More information about the llvm-commits mailing list