[PATCH] D33240: [Atomics] Rename and change prototype for atomic memcpy intrinsic

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 28 22:50:02 PDT 2017


skatkov added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4878
 
-    Entry.Ty = I.getArgOperand(2)->getType();
-    Entry.Node = NumElements;
+    Entry.Ty = MI.getLength()->getType();
+    Entry.Node = Length;
----------------
MI.getLength() == Length


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:109
+  uint8_t ElementSizeInBytes = AMI->getElementSizeInBytes();
+  uint64_t NumElements = LengthInBytes / ElementSizeInBytes;
   if (NumElements >= UnfoldElementAtomicMemcpyMaxElements)
----------------
assert LengthInBytes % ElementSizeInBytes == 0 and LengthInBytes > 0?


https://reviews.llvm.org/D33240





More information about the llvm-commits mailing list