[PATCH] D33618: [PartialInlining] Reduce function outlining overhead

[David Li via Phabricator via llvm-commits]

davidxl marked 4 inline comments as done.
davidxl added inline comments.


================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:200-202
       for (User::op_iterator OI = II.op_begin(), OE = II.op_end(); OI != OE;
-           ++OI)
-        if (definedInCaller(Blocks, *OI))
-          Inputs.insert(*OI);
+           ++OI) {
+        Value *V = *OI;
----------------
davide wrote:
> While you're here, I'd see if you can use a `range for` instead (and maybe avoid the extra assignment to value, but I'm not sure if it's possible).
This will need begin/end methods in Instruction.


https://reviews.llvm.org/D33618