[PATCH] D32756: [DAGCombine] Refactor common addcarry pattern.

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2224
+    if (Y.getOpcode() == ISD::UADDO &&
+        CarryIn.getOpcode() == ISD::ADDCARRY &&
+        isNullConstant(CarryIn.getOperand(1)) &&
----------------
RKSimon wrote:
> Worth checking/asserting that CarryIn.getResNo() == 1 ?
Sounds like a good idea. i don't think we generate such a code ever, but better safe than sorry.


https://reviews.llvm.org/D32756