[llvm] r304084 - Reverted r304083 as it seems there is a desire to address this in the googletest.

Galina Kistanova via llvm-commits llvm-commits at lists.llvm.org
Sat May 27 22:50:22 PDT 2017


Author: gkistanova
Date: Sun May 28 00:50:22 2017
New Revision: 304084

URL: http://llvm.org/viewvc/llvm-project?rev=304084&view=rev
Log:
Reverted r304083 as it seems there is a desire to address this in the googletest.

Modified:
    llvm/trunk/unittests/Support/CommandLineTest.cpp

Modified: llvm/trunk/unittests/Support/CommandLineTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/CommandLineTest.cpp?rev=304084&r1=304083&r2=304084&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/CommandLineTest.cpp (original)
+++ llvm/trunk/unittests/Support/CommandLineTest.cpp Sun May 28 00:50:22 2017
@@ -180,9 +180,8 @@ void testCommandLineTokenizer(ParserFunc
   parse(Input, Saver, Actual, /*MarkEOLs=*/false);
   EXPECT_EQ(OutputSize, Actual.size());
   for (unsigned I = 0, E = Actual.size(); I != E; ++I) {
-    if (I < OutputSize) {
+    if (I < OutputSize)
       EXPECT_STREQ(Output[I], Actual[I]);
-    }
   }
 }
 
@@ -529,9 +528,8 @@ TEST(CommandLineTest, GetRegisteredSubco
   EXPECT_FALSE(Opt1);
   EXPECT_FALSE(Opt2);
   for (auto *S : cl::getRegisteredSubcommands()) {
-    if (*S) {
+    if (*S)
       EXPECT_EQ("sc1", S->getName());
-    }
   }
 
   cl::ResetAllOptionOccurrences();
@@ -540,9 +538,8 @@ TEST(CommandLineTest, GetRegisteredSubco
   EXPECT_FALSE(Opt1);
   EXPECT_FALSE(Opt2);
   for (auto *S : cl::getRegisteredSubcommands()) {
-    if (*S) {
+    if (*S)
       EXPECT_EQ("sc2", S->getName());
-    }
   }
 }
 




More information about the llvm-commits mailing list