[PATCH] D33485: [ELF] - Do not allow -r to eat comdats.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 27 03:07:45 PDT 2017
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/InputSection.cpp:305
+ // First entry is a flag word, we leave it unchanged.
+ write32(To++, From[0], support::endianness::native);
+
----------------
`endianness::native` is alarming although it is actually correct. It is better to write
*To++ = From[0];
https://reviews.llvm.org/D33485
More information about the llvm-commits
mailing list