[PATCH] D33614: Cloning: Fix debug info cloning
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 20:00:06 PDT 2017
dblaikie added a comment.
(once you've sent something for review, please wait until it's approved - generally the assumption/concensus is that if a developer asks for review, it's because it's needed - submitting then without review/sign off indicates that maybe the required review didn't happen, which isn't good)
================
Comment at: lib/IR/DebugLoc.cpp:170
+
+ auto *NewVar = DILocalVariable::get(
+ Ctx,
----------------
Is there a reason this can't be distinct anymore?
You mentioned in the description: "I added caching, but, it is not sufficient, since dbg.value may refer to various expressions representing the same user var, thus, switching form getDistinct to get is important."
But I don't follow quite what you're saying there - could you explain it in more detail/in another way?
What happens without changing this to 'get'?
https://reviews.llvm.org/D33614
More information about the llvm-commits
mailing list