[PATCH] D33584: Remove a quadratic behavior in assert-enabled builds

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 15:16:28 PDT 2017


sanjoy added a comment.

In https://reviews.llvm.org/D33584#766182, @anemet wrote:

> I certainly agree that if we're not returning false for the non-unique edge case then that will cause bugs later on.
>
> Can I add unit-tests for edge-domination somehow?  I am trying to test this with allowing non-unique edges in GVN but that won't fly as regression test.


I'd just go with a regular C++ test case in unittests/


https://reviews.llvm.org/D33584





More information about the llvm-commits mailing list