[PATCH] D33384: [libcxx] [libcxxabi] fix building with libc++ win32 threads for mingw-w64

[Eric Fiselier via Phabricator via llvm-commits]

EricWF added a comment.

Why do we *need* to set it? Doesn't `_WIN32_WINNT` default to the current platform?



================
Comment at: libcxx/trunk/cmake/config-ix.cmake:53
     list(APPEND CMAKE_REQUIRED_LIBRARIES ${MINGW_LIBRARIES})
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D_WIN32_WINNT=0x0600")
   endif()
----------------
Shouldn't we use `add_definitions` ?


Repository:
  rL LLVM

https://reviews.llvm.org/D33384