[PATCH] D33515: Add overloads for RegisterStandardPasses and PassManagerBuilder::addGlobalExtension
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 11:51:06 PDT 2017
efriedma added inline comments.
================
Comment at: include/llvm/Transforms/IPO/PassManagerBuilder.h:184
+ static void addGlobalExtension(ExtensionPointTy Ty, ExtensionProc Fn);
static void addGlobalExtension(ExtensionPointTy Ty, ExtensionFn Fn);
void addExtension(ExtensionPointTy Ty, ExtensionFn Fn);
----------------
Overloading like this seems a little dubious; if the ExtensionProc overload is the only one that's actually reliably usable, we shouldn't expose the ExtensionFn overload.
https://reviews.llvm.org/D33515
More information about the llvm-commits
mailing list