[PATCH] D33567: [InstCombine] Pass the DominatorTree and AssumptionCache to a few calls to isKnownPositive, isKnownNegative, and isKnownNonZero
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 10:11:44 PDT 2017
craig.topper added a comment.
I was operating under the assumption that this was an accident. Most other places use the InstCombine specific wrappers around computeKnownBits so always pass the the dominatortree and assumption cache. If there's a reason for these places to be different then that should be commented.
https://reviews.llvm.org/D33567
More information about the llvm-commits
mailing list