[PATCH] D33552: [ELF] - Make implementation of .gdb index to be more natural for futher paralleling.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/SyntheticSections.h:512-513
 
-  // Pairs of [CU Offset, CU length].
-  std::vector<std::pair<uint64_t, uint64_t>> CompilationUnits;
-
-  llvm::StringTableBuilder StringPool;
-
+  // Symbol table is an hash table for types and names.
+  // It is a separate area of gdb index.
   GdbHashTab SymbolTable;
----------------
ruiu wrote:
> ruiu wrote:
> > an -> a
> Do you mean that the hash table is a map from names to their types? I don't quite get what "it is a separate area ..." means.
I was just mean that it is also an area: "A mapped index consists of several areas, laid out in order: ... 5. The symbol table. This is an open-addressed hash table."
(https://sourceware.org/gdb/onlinedocs/gdb/Index-Section-Format.html)

Because "is an hash table" itself sounds like some container for something else for me.


https://reviews.llvm.org/D33552