[PATCH] D33548: [DWARF] - Cleanup relocation handling.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 08:53:25 PDT 2017


grimar added inline comments.


================
Comment at: include/llvm/Object/RelocVisitor.h:62
+                                            uint64_t Value);
+  Visitor Vis;
+
----------------
ruiu wrote:
> Why don't you use std::function?
I am pretty sure I was asked by somebody to use poiner in one of reviews earlier, do not really remember why, so
I supposed it is preferred in LLVM before your comment, though it looks std::function is used widely. So I can switch to it.


https://reviews.llvm.org/D33548





More information about the llvm-commits mailing list