[PATCH] D33575: [llvm-ar] Make llvm-lib behave more like the MSVC archiver

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 17:55:40 PDT 2017


> The names we invent for import files don't have path separators in them, so
> there should be no behavior change either way here. By passing true, we
> don't needlessly run sys::path::filename on them. Are you suggesting that
> maybe it will cause us to not use the short strtab format? I guess I'll
> change it back. Most DLL names are < 16 characters.

How about passing the final name to useStringTable? That way it can just
check if there is '/' in it or if it is too large.

Cheers,
Rafael


More information about the llvm-commits mailing list