[PATCH] D33388: [libcxx] fixup bootstrapping for mingw-w64

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 16:58:50 PDT 2017


martell added inline comments.


================
Comment at: libcxx/trunk/cmake/config-ix.cmake:45
+    if (LIBCXX_USE_COMPILER_RT)
+      set(MINGW_RUNTIME ${LIBCXXABI_BUILTINS_LIBRARY})
+    else ()
----------------
EricWF wrote:
> `LIBCXXABI_BUILTINS_LIBRARY` isn't defined by libc++ and we can't count on it being available here. I think you need to duplicate the logic from libc++abi into libc++.
The older versions of the patch didn't have `LIBCXXABI`
I went to cherry pick the commit onto master to push and got an older version I never meant to.
So I manually re added the changes. Thanks for pushing the fix for this.


Repository:
  rL LLVM

https://reviews.llvm.org/D33388





More information about the llvm-commits mailing list