[PATCH] D33575: [llvm-ar] Make llvm-lib behave more like the MSVC archiver

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:187
+static bool useStringTable(bool WriteObjPaths, StringRef Name) {
+  // Force the use of the string table if we're writing full paths.
+  return WriteObjPaths || Name.size() >= 16;
----------------
If it fits in 16 byte buffer, we can write there even if a path contains a path separator, no?


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:246
+    if (WriteObjPaths) {
+      llvm::errs() << ObjPath << '\n';
+      return ObjPath;
----------------
Debug output?


https://reviews.llvm.org/D33575