[PATCH] D33540: [PM/ThinLTO] Port the ThinLTO pipeline (both components) to the new PM.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D33540#764937, @davidxl wrote:

> For partial inlining, leave it consistent with old PM for now.   We can introduce later an internal option to enable/disable pre-thin-link partial inlining and collect more performance number.


Is there a rationale for the position in the old PM? Was this discussed somewhere? I'd almost rather adjust the position in the old PM to be consistent with here. Without data, I think the position I gave it here actually fits with the clear intent indicated by the comments. The previous position, honestly, looked like an accident to me. Maybe it isn't but I couldn't find any really clear reason written down anywhere, and the only test that fails if I reorder these things is just the one that asserts a particular order.

Anyways, I'll change this back to the old PM one for now, but I really do want to understand why this is the right initial ordering to use.


https://reviews.llvm.org/D33540