[lld] r303787 - Simplify a variable type by using StringRef instead of CachedHashStringRef.

[Rui Ueyama via llvm-commits]

On Thu, May 25, 2017 at 2:51 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 25 May 2017 at 13:28, Rui Ueyama <ruiu at google.com> wrote:
> > It took for a while due to the size of the archive, but it is now
> > downloadable here:
> > https://drive.google.com/open?id=0By41E4A3-q0hZ1hNX05tbDAzQzQ
> >
> > Beware: it is 8GB when expanded.
>
> I tried reverting your patch on top of trunk and the result I get on
> this test is:
>
> clang-dbg
>   master 13.262570166
>   patch  13.243235112 1.00145999477x faster
>
> so there is a very small difference, which I guess is expected in a
> slow link with debug info. In other links, specially with -O0 I see an
> improvement, so I will revert the change.
>

Thank you for testing, and your explanation makes sense. If we spent a lot
of time linking debug info, the cost of handling SHT_GROUP becomes
relatively unimportant.

I have added testcase you provided to the set I normally use for
> benchmarking.  I will post the link as soon as the upload is
> completed.
>
> Thanks,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170525/96315f7f/attachment.html>