[PATCH] D33548: [DWARF] - Cleanup relocation handling.

[Rafael Avila de Espindola via llvm-commits]

> Though this approach helps to split huge method and cleanup implementation. 
> Interesting what other thinks about that.

I like the idea of not doing a check on the file type for every
relocation.


> +  void dropError() { HasError = false; };

clearError maybe? We normally use "drop" for ownership.

> +  Visitor createELFVisitor() {
> +    if (ObjToVisit.getArch() == Triple::x86_64)
> +      return &RelocVisitor::visitELF_x86_64;
> +    return &RelocVisitor::visitELF;
> +  }

I would inline or at least rename this. It is not creating anything, it
is just selecting which one to use (like its caller).

Cheers,
Rafael