[PATCH] D33546: Updated getting started guide for visual studio + cmake

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

In https://reviews.llvm.org/D33546#764842, @zturner wrote:

> It might be overkill, but `CMAKE_HOST_SYSTEM_PROCESSOR` probably contains what you need.  In any case, lgtm even without doing that.


I found that, but it spits out the friendly name of the processor, which I'd have to parse for the pertinent information. That seemed too fragile for my tastes.

> Presumably you tested this and confirmed that the warning shows up if and only if you don't specify -Thost=x64?

Yes. In my tests, if you start from a clean build directory and elide the -T entirely, you get a warning. If you specify -T<anything>, you do not get the warning. Once you specify -Thost=x64, if you reconfigure and leave the -T option off, `CMAKE_GENERATOR_TOOLSET` still retains the host=x64 and the project files are sane.

One thing to note: -Tv140 will use the MSVC 2015 32-bit toolset and not generate a warning here. However, I suspect that if you are specifying the -T flag, you already know what you want to have happen.


https://reviews.llvm.org/D33546