[PATCH] D33546: Updated getting started guide for visual studio + cmake

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 13:37:51 PDT 2017


On Thu, May 25, 2017 at 4:28 PM, Mike Stump <mikestump at comcast.net> wrote:
> But, that doesn't prohibit a new feature where cmake allows the project to select a new default for that flag.

Perhaps I'm misunderstanding. CMake already has such a feature:
-Thost=<arch>. If the user specifies an arch explicitly with that flag
(or has previously specified one and is doing a reconfigure), then
CMAKE_GENERATOR_TOOLSET is not an empty string and no warning is
given. If CMake decides to change the default behavior to use the
native toolset and still leaves CMAKE_GENERATOR_TOOLSET as an empty
string (which is possible), we can address that by updating the check
to look at the CMake version used and eventually bumping our required
CMake version (to no longer need the check at all).

~Aaron


More information about the llvm-commits mailing list