[PATCH] D33485: [ELF] - Do not allow -r to eat comdats.

[Rafael Avila de Espindola via llvm-commits]

George Rimar <grimar at accesssoftek.com> writes:

>>>>  static uint64_t getOutFlags(InputSectionBase *S) {
>>>> +  if (Config->Relocatable)
>>>> +    return S->Flags & ~SHF_COMPRESSED;
>>>
>>>Not really related to the patch, but do we decompress in -r? Should we?
>>>Would you mind checking and opening a bug if needed?
>>
>>Yeah, I also noticed that place is wierd when wrote patch, will check it soon.
>
> Returning to this - we decompress them with -r and that is consistent with bfd/gold.
> I think we should. As if we have 2 objects where in both there are compressed .debug_str
> sections for example, would be not clear what to do with them since we need to produce
> single section in output. Decompressing both and compressing into single again does
> not looks reasonable I think, so current behavior looks fine for me.

Sounds good.

Cheers,
Rafael