[PATCH] D33546: Updated getting started guide for visual studio + cmake

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

In https://reviews.llvm.org/D33546#764526, @zturner wrote:

> In https://reviews.llvm.org/D33546#764521, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D33546#764507, @zturner wrote:
> >
> > > Can we just error out if this is not specified and have CMake print the error message?  `CMAKE_GENERATOR_TOOLSET` contains the value at generation time, and we can just check the value and print an error.  Given that you can't successfully build LLVM / clang / etc without it, we might as well fail fast.
> >
> >
> > We can successfully build LLVM/clang/etc without it (I've done so for *far* too long), but you may get some sporadic "linker out of memory" errors (recompiles will eventually link, however). Also, not everyone may want to use the native toolset. I'm thinking about people who may have something like 8GB of RAM, where the x86 linker is less likely to throttle the machine than the x64 linker.
> >
> > Since it does work out of the box, why force users to use an extra command line argument?
>
>
> I've never successfully built clang without using the x64 host toolchain.  At the very least, I think we should print a warning.


I've managed it for five years, entirely by accident (and not without frustration, hence the patch), but a warning seems like a reasonable idea.


https://reviews.llvm.org/D33546