[PATCH] D33546: Updated getting started guide for visual studio + cmake

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 08:39:27 PDT 2017


zturner added a comment.

Can we just error out if this is not specified and have CMake print the error message?  `CMAKE_GENERATOR_TOOLSET` contains the value at generation time, and we can just check the value and print an error.  Given that you can't successfully build LLVM / clang / etc without it, we might as well fail fast.


https://reviews.llvm.org/D33546





More information about the llvm-commits mailing list