[PATCH] D24805: [GVNSink] Initial GVNSink prototype

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 07:45:57 PDT 2017


>
>
> Comment at: lib/Transforms/Scalar/GVNSink.cpp:75
> +
> +/// Iterates through instructions in a set of blocks in reverse order
> from the
> +/// first non-terminator. For example (assume all blocks have size n):
> ----------------
> dberlin wrote:
> > I'm not sure how easy/possible it is to do, but isn't this just a
> zip_iterator of a bunch of reverse iterators?
> >
> Similar; it'd be really cool to have something like zip_iterator in
> STLExtras.


FWIW: We have it in iterator.h :)


> Although this does have some domain-specific utility functions, and
> doens't have undefined behaviour when the input iterators aren't of equal
> length :)
>
> I didn't check if this is true, however.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170525/bcc3db9e/attachment.html>


More information about the llvm-commits mailing list