[PATCH] D33544: [lnt][profile] Add support for X86-64 CFG view

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.

LGTM, modulo considering a call instruction to be ending a basic block.
I don't know enough details about the X86_64 instruction set to judge whether the regular expressions are fully correct, but they look plausible to me.



================
Comment at: lnt/server/ui/static/lnt_profile.js:116-117
+        [new RegExp("^\\s*jmp\\s+([^\\s]+)"), true],
+        // call
+        [new RegExp("^\\s*callq\\s+([^\\s]+)"), true],
+        // ret
----------------
A function call should not be considered as ending a basic block. We also don't do that for the other targets supported here (AArch64 and AArch32).


https://reviews.llvm.org/D33544