[PATCH] D33388: [libcxx] fixup bootstrapping for mingw-w64

[Eric Fiselier via Phabricator via llvm-commits]

EricWF added inline comments.


================
Comment at: libcxx/trunk/cmake/config-ix.cmake:53
+    list(APPEND CMAKE_REQUIRED_LIBRARIES ${MINGW_LIBRARIES})
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D_WIN32_WINNT=0x0600")
   endif()
----------------
chapuni wrote:
> EricWF wrote:
> > `-D_WIN32_WINNT=0x0600`. What? Why?
> > 
> > First isn't `0x0600` Windows Vista? Why are we asking to support such an old operating system?
> > Why are we defining this at all?
> > 
> I think it'd be good thing to require minimum version as the bottom line.
Perhaps, but at minimum this is not the patch to do it in unless it's a required change to make MinGW work, otherwise it should be done as a separate commit because a wider range of Win32 interfaces are used when targeting non-MinGW Windows.


Repository:
  rL LLVM

https://reviews.llvm.org/D33388