[PATCH] D33286: Don't require ThreadState to be contained within tls on all platforms

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 00:51:26 PDT 2017


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit



================
Comment at: lib/tsan/rtl/tsan_platform_mac.cc:259
+    uptr thr_state_end = thr_state_start + sizeof(uptr);
+    MemoryRangeImitateWrite(thr, /*pc=*/2, tls_addr,
+                            thr_state_start - tls_addr);
----------------
Please add CHECKs that thr is in fact located within tls range, similar to linux impl.


https://reviews.llvm.org/D33286





More information about the llvm-commits mailing list