[PATCH] D33535: [PM] Teach the PGO instrumentation pasess to run GlobalDCE before instrumenting code.

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 23:00:06 PDT 2017


On Wed, May 24, 2017 at 10:52 PM, Davide Italiano via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> davide accepted this revision.
> davide added a comment.
> This revision is now accepted and ready to land.
>
> I can see the bloat as we inline with a ridicolously high threshold before
> instrumenting without DCE'ing,


The threshold is 75 which is very low. The hint threshold is 325.

David



> so the patch seems a decent idea.
> Also, DCE is basically free compile-time wise. If you want to improve I'd
> do it on the DCE side instead of the instrumentation side, but that needs a
> larger discussion which definitely doesn't fit in the margin of this page.
>
>
> https://reviews.llvm.org/D33535
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170524/33a9e062/attachment.html>


More information about the llvm-commits mailing list