[PATCH] D33528: [LegacyPM] Make the 'addLoop' method accept a loop to add rather than having it internally allocate the loop.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 17:46:07 PDT 2017


davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

This is fine assuming you audited all the callers (a quick grep shows just these two).



================
Comment at: lib/Analysis/LoopPass.cpp:76
 
 // Inset loop into loop nest (LoopInfo) and loop queue (LQ).
+void LPPassManager::addLoop(Loop &L) {
----------------
this should be insert, I think, but it's not your fault.


https://reviews.llvm.org/D33528





More information about the llvm-commits mailing list