[PATCH] D33496: [LLD][ELF] Move creation of .ARM.exidx sentinel before LinkerScript creation

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 17:05:20 PDT 2017


Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:

> peter.smith created this revision.
> Herald added subscribers: emaste, rengolin, aemerson.
>
> This change moves the creation of the .ARM.exidx sentinel section forward so that it is assigned to an OutputSection/InputSectionDescription with the existing .ARM.exidx sections.
>

It is already before fabricateDefaultCommands, so I assume the problem
is now visible only with a linker script, correct?

The problem, if I understand it, is that we create a
ARMExidxSentinelSection and add it to an OutputSection, but not an
OutputSectionCommand. Is Script->synchronize() currently taking care of
this? If so, can you remove the code that does it in this commit?

Instead of moving the creation earlier, could you add it to a
OutputSectionCommand when it is created at its current position?

Cheers,
Rafael


More information about the llvm-commits mailing list