[PATCH] D33463: [llvm-pdbdump] [yaml2pdb] always include object file name in module info

[Bob Haarman via Phabricator via llvm-commits]

inglorion marked an inline comment as done.
inglorion added inline comments.


================
Comment at: test/DebugInfo/PDB/pdbdump-objfilename.yaml:5-6
+#
+# CHECK: ObjFile:
+# CHECK-SAME: 'C:\src\test.obj'
+---
----------------
zturner wrote:
> Seems better to check the entire text rather than just one field, which would match regardless of what the output looked like, as long as that text appeared.  How about:
> 
> ```
> CHECK:      DbiStream
> CHECK-NEXT:   Modules
> CHECK-NEXT:     - Module:[[ *]]'C:\src\test.obj'
> CHECK-NEXT:       ObjFile:[[ *]]'C:\src\test.obj'
> ```
I made the check a little stricter. "Modules:" is still CHECK instead of CHECK-NEXT, because otherwise we would fail because of other fields that I don't think we care about in this test.


https://reviews.llvm.org/D33463