[PATCH] D33463: [llvm-pdbdump] [yaml2pdb] always include object file name in module info

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 16:11:46 PDT 2017


zturner added inline comments.


================
Comment at: test/DebugInfo/PDB/pdbdump-objfilename.yaml:5-6
+#
+# CHECK: ObjFile:
+# CHECK-SAME: 'C:\src\test.obj'
+---
----------------
Seems better to check the entire text rather than just one field, which would match regardless of what the output looked like, as long as that text appeared.  How about:

```
CHECK:      DbiStream
CHECK-NEXT:   Modules
CHECK-NEXT:     - Module:[[ *]]'C:\src\test.obj'
CHECK-NEXT:       ObjFile:[[ *]]'C:\src\test.obj'
```


https://reviews.llvm.org/D33463





More information about the llvm-commits mailing list