[PATCH] D33524: [coroutines] Allow rematerialization upto 4 times. Remove incorrect assert

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 15:54:18 PDT 2017


majnemer requested changes to this revision.
majnemer added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Transforms/Coroutines/CoroFrame.cpp:817
 
-  // See if there are materializable instructions across suspend points.
-  for (Instruction &I : instructions(F))
-    if (materializable(I))
-      for (User *U : I.users())
-        if (Checker.isDefinitionAcrossSuspend(I, U))
-          Spills.emplace_back(&I, U);
+  for (int repeat = 0; repeat < 4; ++repeat) {
+    // See if there are materializable instructions across suspend points.
----------------
Please abide by the coding convention.


https://reviews.llvm.org/D33524





More information about the llvm-commits mailing list