[PATCH] D33485: [ELF] - Do not allow -r to eat comdats.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Wed May 24 15:36:00 PDT 2017
Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
> ruiu added a comment.
>
> In general, I think we pass through all input sections to an output when the -r option is given. But in this patch you deduplicates comdat groups. Do you need that?
While it should be legal to have two groups with the same signature in a .o
file, it seems better to drop the second one, no?
For what it is worth, both bfd and gold drop it.
Taking a look at the patch.
Cheers,
Rafael
More information about the llvm-commits
mailing list