[PATCH] D33475: [pdb] pad source file name buffer at the end instead of the beginning

[Bob Haarman via Phabricator via llvm-commits]

inglorion added inline comments.


================
Comment at: lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp:132
 
-uint32_t DbiStreamBuilder::calculateFileInfoSubstreamSize() const {
+uint32_t DbiStreamBuilder::calculateNamesOffset() const {
   uint32_t Size = 0;
----------------
amccarth wrote:
> Minor quibble with the name:  This appears to calculate a size rather than an offset.  But that's not really a big deal.
It actually calculates the offset of the file names from the beginning of the file info substream. I think your confusion comes from the accumulator variable being named "Size", which I copy-pastad from claculateFileInfoSubstreamSize. I'll change it to "Offset".


https://reviews.llvm.org/D33475