[PATCH] D33471: [asan] Remove allow_user_segv_handler on Windows.

Wed May 24 14:40:49 PDT 2017

hans added a subscriber: zturner.
hans added a comment.

In https://reviews.llvm.org/D33471#763825, @hans wrote:

> In https://reviews.llvm.org/D33471#763733, @thakis wrote:
>
> > Either this or the reland of making allow_user_segv_handler to true broke this test on Windows:
> >
> >   lit.py: E:/b/build/slave/win_upload_clang/build/src/third_party/llvm/tools/clang/test/lit.cfg:200: note: using clang: 'E:/b/build/slave/win_upload_clang/build/src/third_party/llvm-bootstrap/./bin/clang.EXE'
> >   -- Testing: 33069 tests, 8 threads --
> >   Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.
> >   FAIL: UBSan-Standalone-x86_64 :: TestCases/Integer/negate-overflow.cpp (31844 of 33069)
> >   ******************** TEST 'UBSan-Standalone-x86_64 :: TestCases/Integer/negate-overflow.cpp' FAILED ********************
>
>
> I'm not sure this is the cause. I rolled back compiler-rt to r303422 and the test still fails for me.

The test started failing with Zach's r303440. With that change, lit interprets the exit value as an error.

I'll see if I can just fix the test.

Repository:
  rL LLVM

https://reviews.llvm.org/D33471